This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Make flakey test more permissive #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Hmm, even with this change it fails:
|
|
|
|
Example test failure: https://circleci.com/gh/ethereum/trinity/129012 |
|
A test flaked on a PR meant to fix a different flaking test 🙄 Opened a ticket: #1213 |
pipermerriam
approved these changes
Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
tests/p2p/test_token_bucket.py::test_token_bucket_initial_tokenswas a little flakey, I ran it 10k times (while compiling rust to simulate a bursty load on the CI box) and it failed 8 times. As a quick solution I've made the test more permissive and it hasn't failed on me again.A better solution might be to change the test. I think it's making sure that we never sleep when pulling tokens from a full bucket, maybe this test could mock out the time api, and then check that
sleep()is never called.Cute Animal Picture